[PATCH] D99992: [mlgo] Skip AOT-compiling a model if a header/object pair is provided

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/cmake/modules/TensorFlowCompile.cmake:23-24
+  string(TOUPPER ${fname} fname_allcaps)
+  set(OVERRIDE_HEADER ${LLVM_OVERRIDE_MODEL_HEADER_${fname_allcaps}})
+  set(OVERRIDE_OBJECT ${LLVM_OVERRIDE_MODEL_OBJECT_${fname_allcaps}})
+  if (EXISTS "${OVERRIDE_HEADER}" AND EXISTS "${OVERRIDE_OBJECT}")
----------------
Super minor nit, I'd make these variables lowercase as a signal to the reader that these are local variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99992/new/

https://reviews.llvm.org/D99992