[PATCH] D100383: [LSR] Fix for pre-indexed generated constant offset

[Stelios Ioannou via Phabricator via llvm-commits]

stelios-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:3795
 
     if (isLegalUse(TTI, LU.MinOffset - Offset, LU.MaxOffset - Offset, LU.Kind,
                    LU.AccessTy, F)) {
----------------
dmgreen wrote:
> This looks like it's already checking isLegalUse. Should it be without the -Offset?
Yes that will do. I am not sure whether such change will result in any side effects. I will test it, and if there are none I will update it in the next revision accordingly. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100383/new/

https://reviews.llvm.org/D100383