[PATCH] D100341: [flang] Handle instantiation of procedure pointer components

[Peter Klausler via Phabricator via llvm-commits]

klausler added inline comments.


================
Comment at: flang/lib/Semantics/type.cpp:299
     }
-    newScope.set_instantiationContext(contextMessage);
   }
----------------
Why is the scope's instantiation context no longer needing to be set?  Are you somehow setting it elsewhere?


================
Comment at: flang/lib/Semantics/type.cpp:361
+        // Don't change the type for interfaces based on symbols
+        interface.set_type(*returnType);
+      }
----------------
Are you sure that you're modifying a new ProcInterface created for this procedure pointer component's instantiation, or are you maybe modifying a ProcInterface shared by all instantiation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100341/new/

https://reviews.llvm.org/D100341