[PATCH] D100341: [flang] Handle instantiation of procedure pointer components

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 13:12:40 PDT 2021


PeteSteinfeld created this revision.
PeteSteinfeld added reviewers: klausler, tskeith.
PeteSteinfeld requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

We were not instantiating procedure pointer components.  If the instantiation
contained errors, we were not reporting them.  This resulted in internal errors
in later processing.

I fixed this by adding code in .../lib/Semantics/type.cpp in
InstantiateComponent() to handle a component with ProcEntityDetails.  I also
added several tests for various good and bad instantiations of procedure
pointer components.

One of the tests caused a redundant context message to appear.  I fixed this by
removing a call to set_instantiationContext() from
DerivedTypeSpec::Instantiate().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100341

Files:
  flang/lib/Semantics/type.cpp
  flang/test/Semantics/resolve105.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100341.336943.patch
Type: text/x-patch
Size: 4232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210412/773f22d9/attachment.bin>


More information about the llvm-commits mailing list