[PATCH] D100119: [mlir] Rename AVX512 dialect to X86Vector

Mon Apr 12 08:30:35 PDT 2021

bondhugula added a comment.

In D100119#2681293 <https://reviews.llvm.org/D100119#2681293>, @ftynse wrote:

> In D100119#2681022 <https://reviews.llvm.org/D100119#2681022>, @bondhugula wrote:
>
>> Is there a proposal for the first non AVX op to be added to this and which one it would be?
>
> There is a patch, D99818 <https://reviews.llvm.org/D99818>, which triggered the discussion about renaming. That patch adds an AVX op. I am highly supportive of renaming the dialect in a separate patch.

I was asking about a "non AVX op" - as you point out, that's adding an AVX op. (I was aware of D99818 <https://reviews.llvm.org/D99818> after Aart referred to that above.)

>> I also see @ftynse suggested going with AVX there.
>
> You must be misreading, I did not suggest this. This will be equally confusing to have AVX512 ops in the AVX dialect and AVX ops in the AVX512 dialect; these are two different

I might have misread the multiply nested context; looks like it was someone else.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100119/new/

https://reviews.llvm.org/D100119