[PATCH] D100300: [AMDGPU] Refactor ds_read/ds_write related select code for better readability.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:1415-1416
 
+    // Either, the alignment requirements are "enabled", or there is an
+    // unaligned LDS access related hardware bug though alignment requirements
+    // are "disabled". In either case, we need to check for proper alignment
----------------
arsenm wrote:
> "related hardware bug" - no idea what this is referring to
This is actually referring to - https://github.com/llvm/llvm-project/blob/6c0a1ed3a94ff34e6d9500cdfd04858b1a6f72aa/llvm/lib/Target/AMDGPU/AMDGPU.td#L175

The boolean function hasLDSMisalignedBug() is used to track it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100300/new/

https://reviews.llvm.org/D100300