[PATCH] D100159: Support: Add move semantics to mapped_file_region

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/include/llvm/Support/FileSystem.h:1289-1291
+
+  mapped_file_region(const mapped_file_region &) = delete;
+  mapped_file_region &operator=(const mapped_file_region &) = delete;
----------------
dexonsmith wrote:
> dblaikie wrote:
> > This is the default/doesn't need to be written, since the type has user-declared move ops, so they could be omitted - but don't mind if you prefer to have them here for documentation.
> I left this in, as I find it's a bit clearer for reading, but if the style is moving away from that I don't feel strongly.
Nah, don't think there's any major prevailing take on that - do whatever you reckon is most readable!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100159/new/

https://reviews.llvm.org/D100159