[PATCH] D100159: Support: Add move semantics to mapped_file_region

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

Thanks for the review! Landed in 0db6488a7704a322ae05f20ef3466bed3eb1bb98 <https://reviews.llvm.org/rG0db6488a7704a322ae05f20ef3466bed3eb1bb98>.



================
Comment at: llvm/include/llvm/Support/FileSystem.h:1289-1291
+
+  mapped_file_region(const mapped_file_region &) = delete;
+  mapped_file_region &operator=(const mapped_file_region &) = delete;
----------------
dblaikie wrote:
> This is the default/doesn't need to be written, since the type has user-declared move ops, so they could be omitted - but don't mind if you prefer to have them here for documentation.
I left this in, as I find it's a bit clearer for reading, but if the style is moving away from that I don't feel strongly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100159/new/

https://reviews.llvm.org/D100159