[PATCH] D100119: [mlir] Rename AVX512 dialect to X86Vector

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

> We will soon be adding non-AVX512 operations to MLIR, such as AVX's rsqrt. In https://reviews.llvm.org/D99818 several possibilities were discussed, namely to (1) add non-AVX512 ops to 
> the AVX512 dialect, (2) add more dialects (e.g. AVX dialect for AVX rsqrt), and (3) expand the scope of the AVX512 to include these SIMD x86 ops, thereby renaming the dialect to 
> something more accurate such as X86Vector.
> Consensus was reached on option (3), which this patch implements.

Are you sure about adding non AVX ops to this, i.e., renaming this to X86Vector vs just to AVX? It was a bit confusing without the reference to the `rsqrt` revision, which would still keep this dialect to  AVX. I see that there was a consensus on D99818 <https://reviews.llvm.org/D99818> to call this X86Vector, but it's always confusing when the renaming is done before any actual non-AVX ops are added or even a plan for that. Is there a proposal for the first non AVX op to be added to this and which one it would be? I also see @ftynse suggested going with AVX there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100119/new/

https://reviews.llvm.org/D100119