[PATCH] D100119: [mlir] Rename AVX512 dialect to X86Vector

[Aart Bik via Phabricator via llvm-commits]

aartbik accepted this revision.
aartbik added inline comments.


================
Comment at: mlir/include/mlir/Dialect/X86Vector/Transforms.h:1
+//=- Transforms.h - X86Vector Dialect Transformation Entrypoints -*- C++ -*-=//
+//
----------------
cota wrote:
> aartbik wrote:
> > Just curious, why does this file (and the cmake) still show up as delete/add pair
> That depends on the similarity index that git uses:
> 
> ```
> $ git diff help
> [...]
> -M[<n>], --find-renames[=<n>]
>            Detect renames. If n is specified, it is a threshold on the similarity index (i.e. amount of addition/deletions compared to the file’s size). For example,
>            -M90% means Git should consider a delete/add pair to be a rename if more than 90% of the file hasn’t changed. Without a % sign, the number is to be read as a
>            fraction, with a decimal point before it. I.e., -M5 becomes 0.5, and is thus the same as -M50%. Similarly, -M05 is the same as -M5%. To limit detection to
>            exact renames, use -M100%. The default similarity index is 50%.
> ```
> For instance with -M4 this file is detected as a rename. The CMake file has all of its non-whitespace lines changed so it cannot be detected as a rename even with -M1.
Makes sense. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100119/new/

https://reviews.llvm.org/D100119