[PATCH] D99780: workflows: Add GitHub action for automating some release tasks

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added inline comments.


================
Comment at: .github/workflows/release-tasks.yml:18
+        test "${{ github.actor }}" = "tstellar"
+        echo "${{ github.ref }}" | grep -e 'llvmorg-[0-9.]\+\(-rc[0-9]\+\)\?'$
+        release_version=`echo "${{ github.ref }}" | sed 's/refs\/tags\/llvmorg-//g'`
----------------
Do we have a way to ensure sane tagging? If not, then a tag like `llvmorg-13.0.....1` would match the pattern as well. Do we want to make the versioning scheme more descriptive here? For example, do we always want MAJOR.MINOR.PATCH and optional -RC<0-9>? Then I suggest to change the grep expression to `grep -e '^refs/tags/llvmorg-[0-9]\+\.[0-9]\+\.[0-9]\(-rc[0-9]\+\)\?$'`. With explicit begin `^` and end `$` this will actually result in non-matching tags to be discarded.  


================
Comment at: .github/workflows/release-tasks.yml:24
+      run: |
+        sudo apt-get install doxygen python3-sphinx python3-recommonmark ninja-build graphviz texlive-font-utils python3-github
+        pip3 install --user sphinx-markdown-tables
----------------
Shouldn't this be `sudo apt-get install -y` to run in non-interactive mode?


================
Comment at: .github/workflows/release-tasks.yml:30
+      with:
+        fetch-depth: 1
+
----------------
This line can be omitted because 1 is the default: https://github.com/actions/checkout#usage.


================
Comment at: .github/workflows/release-tasks.yml:34
+      run: |
+         ./llvm/utils/release/./github-upload-release.py --token ${{ github.token }} --release ${{ steps.validate-tag.outputs.release-version }} create
+      
----------------
Remove `./`


================
Comment at: .github/workflows/release-tasks.yml:38
+      run: |
+        bash llvm/utils/release/build-docs.sh -srcdir llvm -release ${{ steps.validate-tag.outputs.release-version }}
+        ./llvm/utils/release/./github-upload-release.py --token ${{ github.token }} --release ${{ steps.validate-tag.outputs.release-version }} upload --files *doxygen*.tar.xz
----------------
I don't see this script in https://github.com/llvm/llvm-project/tree/main/llvm/utils/release nor in this change. What am I missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99780/new/

https://reviews.llvm.org/D99780