[llvm] b62c62c - [Coroutines, test] Fix use of var defined in CHECK-NOT

Thomas Preud'homme via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 01:42:59 PDT 2021


Author: Thomas Preud'homme
Date: 2021-04-07T09:42:58+01:00
New Revision: b62c62c51973f82713477ecba28d0a4bd7c6ee6a

URL: https://github.com/llvm/llvm-project/commit/b62c62c51973f82713477ecba28d0a4bd7c6ee6a
DIFF: https://github.com/llvm/llvm-project/commit/b62c62c51973f82713477ecba28d0a4bd7c6ee6a.diff

LOG: [Coroutines, test] Fix use of var defined in CHECK-NOT

LLVM test Transforms/Coroutine/coro-split-sink-lifetime-O2.ll tries to
check for the absence of a sequence of instructions with several
CHECK-NOT with one of those directives using a variable defined in
another. However CHECK-NOT are checked independently so that is using a
variable defined in a pattern that should not occur in the input.

This commit simplifies the CHECK-NOT block to only check for the
presence of any lifetime start marker since that is effectively what
the test was testing at the moment.

Reviewed By: junparser

Differential Revision: https://reviews.llvm.org/D99856

Added: 
    

Modified: 
    llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll b/llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
index 6695c22a1f09c..645b2a8abddcb 100644
--- a/llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
+++ b/llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll
@@ -57,9 +57,7 @@ exit:
 
 ; CHECK-LABEL: @a.resume(
 ; CHECK:    %[[VAL:testval.+]] = getelementptr inbounds %a.Frame
-; CHECK-NOT:     %testval = alloca i32, align 4
-; CHECK-NOT:     %[[CAST:.+]] = bitcast i32* %testval to i8*
-; CHECK-NOT:     call void @llvm.lifetime.start.p0i8(i64 4, i8* %[[CAST]])
+; CHECK-NOT:     call void @llvm.lifetime.start.p0i8(i64 4, i8* %{{.*}})
 ; CHECK:         %test = load i32, i32* %[[VAL]]
 ; CHECK-NOT:     %test = load i32, i32* %testval
 


        


More information about the llvm-commits mailing list