[PATCH] D100135: [AMDGPU] Check for all meta instrs in GCNRegBankReassign

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 13:36:39 PDT 2021


rampitec added a comment.

In D100135#2677755 <https://reviews.llvm.org/D100135#2677755>, @arsenm wrote:

> If it doesn't make an observable difference, there's no real reason to add the extra check?

There is a difference though. In the last test with KILL %1, %0 before the patch %1 would be reassigned to v3 since v1 and v5 have bank conflict. After the patch it will remain in v5 as assigned which leaves more room for other reassignments. This is a fake conflict. Plus we do not need to spend any time on the false coflicts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100135/new/

https://reviews.llvm.org/D100135



More information about the llvm-commits mailing list