[PATCH] D100072: [AMDGPU] Allow -amdgpu-unsafe-fp-atomics to ignore denorm mode

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 15:47:07 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12058
          Subtarget->hasAtomicFaddInsts()) {
-      if (!fpModeMatchesGlobalFPAtomicMode(RMW) ||
+      if (!fpModeMatchesGlobalFPAtomicMode(RMW) &&
           RMW->getFunction()->getFnAttribute("amdgpu-unsafe-fp-atomics")
----------------
arsenm wrote:
> Probably should add a comment explaining what amdgpu-unsafe-fp-atomics implies and add to the documentation. I assumed it would cover just bypassing the memory scope issue
That was the idea initially. However, our users request to bypass denorm mode checks with that option too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100072/new/

https://reviews.llvm.org/D100072



More information about the llvm-commits mailing list