[PATCH] D100072: [AMDGPU] Allow -amdgpu-unsafe-fp-atomics to ignore denorm mode

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 15:38:21 PDT 2021


arsenm added a comment.

I guess it would be nicer



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12058
          Subtarget->hasAtomicFaddInsts()) {
-      if (!fpModeMatchesGlobalFPAtomicMode(RMW) ||
+      if (!fpModeMatchesGlobalFPAtomicMode(RMW) &&
           RMW->getFunction()->getFnAttribute("amdgpu-unsafe-fp-atomics")
----------------
Probably should add a comment explaining what amdgpu-unsafe-fp-atomics implies and add to the documentation. I assumed it would cover just bypassing the memory scope issue


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100072/new/

https://reviews.llvm.org/D100072



More information about the llvm-commits mailing list