[PATCH] D100069: Disable use of SCC from asm

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 14:10:27 PDT 2021


arsenm added a comment.

Message / name is somewhat confusing since I assumed this meant the scc register



================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4097-4098
+    SMLoc S = getImmLoc(AMDGPUOperand::ImmTyCPol, Operands);
+    StringRef CStr(S.getPointer());
+    S = SMLoc::getFromPointer(&CStr.data()[CStr.find("scc")]);
+    Error(S, "scc is not supported on this GPU");
----------------
I don't think this should be using SMLoc to check the string content. Isn't there an already parsed token?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100069/new/

https://reviews.llvm.org/D100069



More information about the llvm-commits mailing list