[PATCH] D98932: [RISCV] Don't call setHasMultipleConditionRegisters(), so icmp is sunk

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 14:07:51 PDT 2021


luismarques added a comment.

Could you please clean up the test a bit? It contains references to attribute groups that don't actually exist (`#0`, `#1`). One attribute you do want to add is `nounwind`, to avoid the clutter caused by the CFI directives. In manually written tests we also generally don't include some of those `dso_local`, `local_unnamed_addr`, etc. In general, it would be nice to make it look less like Clang's output and more like something that can be easily read and reasoned about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98932/new/

https://reviews.llvm.org/D98932



More information about the llvm-commits mailing list