[PATCH] D100096: [RISCV] Support vector SET[U]LT and SET[U]GE with splatted immediates
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 8 04:16:06 PDT 2021
frasercrmck added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1153
-bool RISCVDAGToDAGISel::selectVSplatSimm5(SDValue N, SDValue &SplatVal) {
+using ValidateFn = bool (*)(int64_t);
+
----------------
I was unsure of this function pointer approach but duplicating all of what was `selectVSplatSimm5` felt silly. It seemed to generate better code than using `std::function<bool(int64_t)>` but my X86 isn't where it should be.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100096/new/
https://reviews.llvm.org/D100096
More information about the llvm-commits
mailing list