[PATCH] D99299: Normalize interaction with boolean attributes

Thu Apr 8 01:50:56 PDT 2021

serge-sans-paille added a comment.

In D99299#2675071 <https://reviews.llvm.org/D99299#2675071>, @nikic wrote:

> As you are now asserting that only certain values are allowed, I believe you also need to add a verifier check that checks this. It should not be possible to assert using a valid module.

Great Idea, will do!

> What is the relation to D99080 <https://reviews.llvm.org/D99080> here? Is this intended as preliminary cleanup for that change, or the final result? I quite liked the direction that one was going...

So was I, but I wanted to prevent any regression. So this is preliminary work on the API side, so that I can do internal change on the representation, without any user code change.
I will try changing the representation of the bool value from str to a real bool...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99299/new/

https://reviews.llvm.org/D99299