[PATCH] D99299: Normalize interaction with boolean attributes

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 13:39:54 PDT 2021


nikic added a comment.

As you are now asserting that only certain values are allowed, I believe you also need to add a verifier check that checks this. It should not be possible to assert using a valid module.

What is the relation to D99080 <https://reviews.llvm.org/D99080> here? Is this intended as preliminary cleanup for that change, or the final result? I quite liked the direction that one was going...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99299/new/

https://reviews.llvm.org/D99299



More information about the llvm-commits mailing list