[PATCH] D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1064-1067
+      std::vector<StringRef> extensions = {".tbd"};
+      for (const Arg *arg : args.filtered(OPT_sub_umbrella)) {
+        reexportHandler(arg, extensions);
+      }
----------------
int3 wrote:
> 1. no need for braces
> 2. I'm pretty sure the compiler can hoist out the construction of the vector
> I'm pretty sure the compiler can hoist out the construction of the vector

well, I'm wrong: https://godbolt.org/z/szKbeojrd


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100019/new/

https://reviews.llvm.org/D100019