[PATCH] D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 08:31:14 PDT 2021


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

I actually snuck in a clang-format cleanup yesterday :) https://github.com/llvm/llvm-project/commit/174deb0539ee4af7d20bfead9f73055782e878e3 (so just update the commit title I guess)



================
Comment at: lld/MachO/Driver.cpp:1064-1067
+      std::vector<StringRef> extensions = {".tbd"};
+      for (const Arg *arg : args.filtered(OPT_sub_umbrella)) {
+        reexportHandler(arg, extensions);
+      }
----------------
1. no need for braces
2. I'm pretty sure the compiler can hoist out the construction of the vector


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100019/new/

https://reviews.llvm.org/D100019



More information about the llvm-commits mailing list