[PATCH] D100025: [CodeGen][AArch64] Fix isel crash for truncating FP stores
David Sherwood via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 7 06:56:05 PDT 2021
david-arm added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1183
MVT::nxv4f32, MVT::nxv2f64}) {
+ for (auto InnerVT : {MVT::nxv2f16, MVT::nxv4f16, MVT::nxv8f16,
+ MVT::nxv2f32, MVT::nxv4f32, MVT::nxv2f64})
----------------
sdesmalen wrote:
> nit: could you leave a comment explaining why this is set to Expand?
Sure, there is no comment for the Neon case that I can borrow from, but I can write something like this if that seems reasonable?
// Avoid marking truncating FP stores as legal to prevent the DAGCombiner from creating
// unsupported truncating stores.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100025/new/
https://reviews.llvm.org/D100025
More information about the llvm-commits
mailing list