[PATCH] D100025: [CodeGen][AArch64] Fix isel crash for truncating FP stores

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1183
                     MVT::nxv4f32, MVT::nxv2f64}) {
+      for (auto InnerVT : {MVT::nxv2f16, MVT::nxv4f16, MVT::nxv8f16,
+                           MVT::nxv2f32, MVT::nxv4f32, MVT::nxv2f64})
----------------
nit: could you leave a comment explaining why this is set to Expand?


================
Comment at: llvm/test/CodeGen/AArch64/sve-fptrunc-store.ll:3
+; RUN: llc -mtriple=aarch64--linux-gnu -mattr=+sve < %s 2>%t | FileCheck %s
+; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
+
----------------
This check for a warning is no longer necessary since D98856


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100025/new/

https://reviews.llvm.org/D100025