[PATCH] D97407: [LoopUnrollAndJam] Avoid repeated instructions for UAJ analysis

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM, so long as the test is cleaned up a little



================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/unroll-and-jam-many-instr.ll:11
+
+; Function Attrs: nofree norecurse nounwind
+; Check that the loop won't be UAJ and it will finish.
----------------
Can remove these Function Attrs comment.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/unroll-and-jam-many-instr.ll:22
+; CHECK: for.end27
+define dso_local void @test1(i32 %i) local_unnamed_addr #0 {
+entry:
----------------
Can remove dso_local and local_unnamed_addr #0


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/unroll-and-jam-many-instr.ll:374
+; Function Attrs: norecurse nounwind readnone
+define dso_local i32 @main() local_unnamed_addr #1 {
+entry:
----------------
You can remove this main function.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/unroll-and-jam-many-instr.ll:379
+
+!1 = !{!2, !2, i64 0}
+!2 = !{!"int", !3, i64 0}
----------------
Often a lot of these can be removed, so long as the tbaa metadata is also removed from the load/store instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97407/new/

https://reviews.llvm.org/D97407