[PATCH] D99834: Don't check that std::pair is trivially copyable on FreeBSD

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 11:48:16 PDT 2021


ldionne added inline comments.


================
Comment at: llvm/unittests/Support/TypeTraitsTest.cpp:113
   TrivialityTester<std::function<int()>, false, false>();
+#if !defined(_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR)
   TrivialityTester<std::pair<int, bool>, true, true>();
----------------
I'm really not fond of using a libc++ internal macro here. I think we should instead detect that we're on FreeBSD.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99834/new/

https://reviews.llvm.org/D99834



More information about the llvm-commits mailing list