[PATCH] D99906: [PowerPC] Materialize 34-bit constants with pli directly

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 6 05:42:51 PDT 2021


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM with a comment-related nit.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1062
   // The pli instruction can materialize up to 34 bits directly.
   // It is defined in the TD file and so we just return the constant.
   if (isInt<34>(Imm))
----------------
Nit: this clearly doesn't apply any longer. Please updated it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99906/new/

https://reviews.llvm.org/D99906



More information about the llvm-commits mailing list