[PATCH] D98994: NFC. Refactored DIPrinter for better support of new print styles.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 4 19:12:02 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me - one optional rename. I don't have a great idea of an alternative though.



================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h:63
+
+class PlainPrinterBase : public DIPrinter {
+protected:
----------------
Might be worth renaming this - I'm not sure "Plain" is obviously "not JSON or YAML or whatever". Human readable? Something else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98994/new/

https://reviews.llvm.org/D98994



More information about the llvm-commits mailing list