[PATCH] D99286: [AsmParser][SystemZ][z/OS] Add in support to only use CommentString as a possible comment syntax

[Anirudh Prasad via Phabricator via llvm-commits]

anirudhp added a comment.

In D99286#2667966 <https://reviews.llvm.org/D99286#2667966>, @MaskRay wrote:

> If the C and BCPL style comments don't cause conflict with HLASM, I'd rather we don't add any code. We don't necessarily reject syntax which are unlikely used incorrectly by the user.

They do cause "conflict". HLASM currently does not treat the additional comment strings as "comments".

> If such distinction is really needed, maybe name the variable with a positive meaning, e.g. AllowCCommentMarker, instead of Only* (Disallow*).

How about a new field called `AllowAdditionalComments` instead? This will encapsulate allowing the C-style line and block comments, and the "#" string as additional comment strings in addition to the CommentString attribute.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99286/new/

https://reviews.llvm.org/D99286