[PATCH] D99286: [AsmParser][SystemZ][z/OS] Add in support to only use CommentString as a possible comment syntax

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 4 01:09:46 PDT 2021


MaskRay added a comment.

If the C and BCPL style comments don't cause conflict with HLASM, I'd rather we don't add any code. We don't necessarily reject syntax which are unlikely used incorrectly by the user.
If such distinction is really needed, maybe name the variable with a positive meaning, e.g. AllowCCommentMarker, instead of Only* (Disallow*).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99286/new/

https://reviews.llvm.org/D99286



More information about the llvm-commits mailing list