[PATCH] D99823: [lld-macho] Add 32-bit compact unwind support

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/UnwindInfoSection.cpp:210
       continue;
-    uint32_t personalityOffset = cu->personality - in.header->addr;
     // Linear search is fast enough for a small array.
----------------
Taking the address difference here doesn't make sense since at this point in the link, `personality` contains an index, not a real address (see the comments on lines 189-191 above.)


================
Comment at: lld/MachO/UnwindInfoSection.cpp:451
+    *i32p++ =
+        in.got->addr + (personality - 1) * target->wordSize - in.header->addr;
 
----------------
this is the right place to be taking the offset from the header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99823/new/

https://reviews.llvm.org/D99823