[PATCH] D99666: [flang] Implement reductions in the runtime

[مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits]

MehdiChinoune added a comment.

Another issues with MSVC:
1 - MSVC doesn't have `__uint128` and `__int128`.
MSVC doesn't accept that portable Int128 type defined in uint128.h to be linked with a C function.
Maybe you should disable int128 intrinsic functions on the platforms where `__unit128` and `__int128` are not available

  D:\dev\llvm-project\flang\runtime\numeric.h(90): error C2526: '_FortranACeiling4_16': C linkage function cannot return C++ class 'Fortran::common::Int128<true>'
  D:\dev\llvm-project\flang\include\flang/Common/uint128.h(257): note: see declaration of 'Fortran::common::Int128<true>'

2- Please include `<complex.h>` in `complex_reduction.h` for MSVC complex types (_Fcomplex,_Dcomplex).



================
Comment at: flang/runtime/complex-reduction.h:29
+typedef double _Complex double_Complex_t;
+typedef long double long_double_Complex_t;
+#endif
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99666/new/

https://reviews.llvm.org/D99666