[PATCH] D99666: [flang] Implement reductions in the runtime

مهدي شينون (Mehdi Chinoune) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 2 03:19:18 PDT 2021


MehdiChinoune added a comment.

This commit breaks Building on MSVC.



================
Comment at: flang/lib/Decimal/binary-to-decimal.cpp:353
 
-#if __x86_64__ && !defined(_MSC_VER)
 ConversionToDecimalResult ConvertLongDoubleToDecimal(char *buffer,
----------------
MehdiChinoune wrote:
> Did you test this commit with MSVC before removing these conditions.
> Because it fails with MSVC.
> Did you test this commit with MSVC before removing these conditions.
> Because it fails with MSVC.

this condition should be replaced by #ifdef LONG_DOUBLE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99666/new/

https://reviews.llvm.org/D99666



More information about the llvm-commits mailing list