[PATCH] D99778: [Hexagon, test] Fix use of undef FileCheck var

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 1 16:58:47 PDT 2021


thopre created this revision.
thopre added reviewers: bcahoon, iajbar, sundeepk.
thopre requested review of this revision.
Herald added a project: LLVM.

LLVM test CodeGen/Hexagon/hwloop3.ll tries to check for the absence of a
sequence of consecutive instructions with several CHECK-NOT with one of
those directives using a variable defined in another. However CHECK-NOT
are checked independently so that is using a variable defined in a
pattern that should not occur in the input.

This commit merges the two CHECK-NOT into a single CHECK-NOT that
matches the content of two successive non-blank lines, thereby allowing
to preserve the intent of the test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99778

Files:
  llvm/test/CodeGen/Hexagon/hwloop3.ll


Index: llvm/test/CodeGen/Hexagon/hwloop3.ll
===================================================================
--- llvm/test/CodeGen/Hexagon/hwloop3.ll
+++ llvm/test/CodeGen/Hexagon/hwloop3.ll
@@ -3,8 +3,7 @@
 ; Remove the unconditional jump to following instruction.
 
 ; CHECK: endloop0
-; CHECK-NOT: jump [[L1:.]]
-; CHECK-NOT: [[L1]]
+; CHECK-NOT: jump [[L1:.]]{{.*[[:space:]]+}}[[L1]]
 
 define void @test(i32* nocapture %a, i32 %n) nounwind {
 entry:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99778.334861.patch
Type: text/x-patch
Size: 458 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210401/fc1d6833/attachment.bin>


More information about the llvm-commits mailing list