[PATCH] D99374: [AsmParser][SystemZ][z/OS] Add support to AsmLexer to accept HLASM style integers

[Eric Astor via Phabricator via llvm-commits]

epastor requested changes to this revision.
epastor added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:327-328
+  if (LexHLASMIntegers) {
+    // You can have leading 0s in HLASM-flavour integers
+    // They don't mean octal integers
+    unsigned Radix = doHexLookAhead(CurPtr, 10, /*LexMasmIntegers=*/false);
----------------
Can we save a lot of code here by removing this whole segment and making the decimal parsing below work even with leading 0 when LexHLASMIntegers is set?

Right now, this seems very redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99374/new/

https://reviews.llvm.org/D99374