[PATCH] D98577: [InlineCost] Compute the savings of switch statements and SROA in the cost benefit analysis

[Liqiang Tao via Phabricator via llvm-commits]

taolq updated this revision to Diff 333832.
taolq added a comment.

Remove TODO comment that consider other forms of savings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98577/new/

https://reviews.llvm.org/D98577

Files:
  llvm/lib/Analysis/InlineCost.cpp


Index: llvm/lib/Analysis/InlineCost.cpp
===================================================================
--- llvm/lib/Analysis/InlineCost.cpp
+++ llvm/lib/Analysis/InlineCost.cpp
@@ -749,9 +749,6 @@
             CurrentSavings += InlineConstants::InstrCost;
           }
         }
-        // TODO: Consider other forms of savings like switch statements,
-        // indirect calls becoming direct, SROACostSavings, LoadEliminationCost,
-        // etc.
       }
 
       auto ProfileCount = CalleeBFI->getBlockProfileCount(&BB);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98577.333832.patch
Type: text/x-patch
Size: 534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210329/ef599df2/attachment.bin>