[PATCH] D99707: Remove "Rewrite Symbols" from codegen pipeline
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 1 11:10:09 PDT 2021
rnk added a subscriber: compnerd.
rnk added a comment.
+ at compnerd
> With empty parameters, it's a no-op and also breaks up the function pass manager.
I'm not sure it's actually a no-op, see the constructor which parses a cl::opt provided file:
https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Transforms/Utils/SymbolRewriter.h#L122
RewriteSymbolPass() { loadAndParseMapFiles(); }
To preserve the functionality, we would need to make adding the pass conditional on the cl::opt being empty. OTOH, I'm not convinced that anyone is actually using this functionality. The top search hits for the command line flag are the Doxygen for the source files.
When this lands, please split it into a straight revert of the function symbol patch the pipeline adjustment change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99707/new/
https://reviews.llvm.org/D99707
More information about the llvm-commits
mailing list