[PATCH] D99707: Remove "Rewrite Symbols" from codegen pipeline

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added reviewers: rnk, MaskRay.
Herald added subscribers: nikic, pengfei, hiraditya.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

With empty parameters, it's a no-op and also breaks up the function pass
manager.

This also reverts commit 9583a3f2625818b78c0cf6d473cdedb9f23ad82c <https://reviews.llvm.org/rG9583a3f2625818b78c0cf6d473cdedb9f23ad82c>:
"[AsmPrinter] Delete dead takeDeletedSymbsForFunction()".
This was not NFC as initially thought. By coalescing two function
psas managers, this exposed the reverted code as necessary.
addr-label.ll was crashing due to an emitted blockaddress's block being
removed but the label not emitted.

Some tests relied on the fact that we had a module pass somewhere in the
codegen pipeline.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99707

Files:
  llvm/include/llvm/CodeGen/MachineModuleInfo.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/MachineModuleInfo.cpp
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/test/CodeGen/AArch64/O0-pipeline.ll
  llvm/test/CodeGen/AArch64/O3-pipeline.ll
  llvm/test/CodeGen/ARM/O3-pipeline.ll
  llvm/test/CodeGen/Generic/addr-label.ll
  llvm/test/CodeGen/X86/O0-pipeline.ll
  llvm/test/CodeGen/X86/opt-pipeline.ll
  llvm/test/CodeGen/X86/select_meta.ll
  llvm/test/Other/2010-05-06-Printer.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99707.334597.patch
Type: text/x-patch
Size: 9704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210401/d17eec5b/attachment.bin>