[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added a comment.

In D98232#2661843 <https://reviews.llvm.org/D98232#2661843>, @aditya_nandakumar wrote:

> In D98232#2661823 <https://reviews.llvm.org/D98232#2661823>, @qcolombet wrote:
>
>>> @aditya_nandakumar @qcolombet any idea when a better fix for that issue might be available?
>>
>> Given Aditya did the prototype I let him comment on that, but I don't expect we land something anytime soon (i.e., at least a couple of months).
>
> That sounds like a reasonable estimate of when I can get it upstreamed.





================
Comment at: llvm/test/CodeGen/X86/bug26810.ll:1
-; RUN: llc < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
+; RUN: llc -consider-local-interval-cost < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
 ; Make sure bad eviction sequence doesnt occur
----------------
dmgreen wrote:
> mtrofin wrote:
> > dmgreen wrote:
> > > If we are enabling this flag by default, we should probably update the tests, not hide them behind a flag.
> > We're not enabling it by default though, that'd regress compile time.
> Ah, yes. I meant "If we are disabling this flag.."
Ah, I wanted to keep some regression testing for the behavior behind the flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232