[PATCH] D98232: [regalloc] Ensure Query::collectInterferringVregs is called before interval iteration

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.

Thanks for the test update. Reluctantly, this LGTM.



================
Comment at: llvm/test/CodeGen/X86/bug26810.ll:1
-; RUN: llc < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
+; RUN: llc -consider-local-interval-cost < %s -march=x86 -regalloc=greedy -stop-after=greedy | FileCheck %s
 ; Make sure bad eviction sequence doesnt occur
----------------
mtrofin wrote:
> dmgreen wrote:
> > If we are enabling this flag by default, we should probably update the tests, not hide them behind a flag.
> We're not enabling it by default though, that'd regress compile time.
Ah, yes. I meant "If we are disabling this flag.."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98232/new/

https://reviews.llvm.org/D98232