[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added inline comments.


================
Comment at: llvm/include/llvm/InterfaceStub/ELFStub.h:56
+  ELFSymbol() = default;
   ELFSymbol(std::string SymbolName) : Name(SymbolName) {}
   std::string Name;
----------------
plotfi wrote:
> alexshap wrote:
> > 1. explicit
> > 
> > 2. Name(std::move(SymbolName))
> Does this need to be a std::move? 
Ah never mind, I see. Ignore my previous std::move comment. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399