[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 31 17:07:50 PDT 2021
plotfi added inline comments.
================
Comment at: llvm/include/llvm/InterfaceStub/ELFStub.h:56
+ ELFSymbol() = default;
ELFSymbol(std::string SymbolName) : Name(SymbolName) {}
std::string Name;
----------------
alexshap wrote:
> 1. explicit
>
> 2. Name(std::move(SymbolName))
Does this need to be a std::move?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99399/new/
https://reviews.llvm.org/D99399
More information about the llvm-commits
mailing list