[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 31 16:13:42 PDT 2021


plotfi added inline comments.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:198
+  else
+    YamlOut << *dynamic_cast<ELFStub *>(CopyStub.get());
+  return Error::success();
----------------
haowei wrote:
> plotfi wrote:
> > Do we even support dynamic_casts in LLVM anymore? I might be missing something here, sorry. 
> I tried dyn_cast seems not working.  Not sure if dynamic_casts is allowed or not so I just change it static_cast.
LLVM is compiled with no-rtti and no exceptions afaik. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399



More information about the llvm-commits mailing list