[PATCH] D99399: [elfabi] Prepare llvm-elfabi for elfabi/ifs merging.

[Haowei Wu via Phabricator via llvm-commits]

haowei marked 5 inline comments as done.
haowei added inline comments.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:198
+  else
+    YamlOut << *dynamic_cast<ELFStub *>(CopyStub.get());
+  return Error::success();
----------------
plotfi wrote:
> Do we even support dynamic_casts in LLVM anymore? I might be missing something here, sorry. 
I tried dyn_cast seems not working.  Not sure if dynamic_casts is allowed or not so I just change it static_cast.


================
Comment at: llvm/lib/InterfaceStub/TBEHandler.cpp:138
+      IO.setError("Not a .tbe YAML file.");
+    IO.mapRequired("TbeVersion", Stub.TbeVersion);
+    IO.mapOptional("SoName", Stub.SoName);
----------------
plotfi wrote:
> phosek wrote:
> > Would this eventually become `IFSVersion`?
> I think I would be OK with IFSVersion and TBE version sharing the same number. 
It will eventually be IFSVersion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99399/new/

https://reviews.llvm.org/D99399