[PATCH] D99192: [NFC] Add tests for scalable vectorization of loops with large stride acesses

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Hey David,
I believe I have some nit. :)



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-large-strides.ll:5
+; CHECK-LABEL: @stride7_i32(
+; CHECK:      vector.body
+; CHECK:        %[[VEC_IND:.*]] = phi <vscale x 4 x i64> [ %{{.*}}, %vector.ph ], [ %{{.*}}, %vector.body ]
----------------
Why do many spaces between CHECK and the instructions?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-large-strides.ll:11
+; CHECK-NEXT:   %[[VALS:.*]] = add nsw <vscale x 4 x i32> %[[GLOAD]],
+; CHECK-NEXT:   call void @llvm.masked.scatter.nxv4i32.nxv4p0i32(<vscale x 4 x i32> %[[VALS]], <vscale x 4 x i32*> %[[PTRS]]
+entry:
----------------
Is there any reason to be more than 1 space?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-large-strides.ll:32
+; CHECK-LABEL: @stride7_f64(
+; CHECK:      vector.body
+; CHECK:        %[[VEC_IND:.*]] = phi <vscale x 2 x i64> [ %{{.*}}, %vector.ph ], [ %{{.*}}, %vector.body ]
----------------
Could this be label too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99192/new/

https://reviews.llvm.org/D99192