[PATCH] D99626: [llvm-objcopy] Unify format specific options check.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 20:35:33 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Seems OK /if/ we go in the direction of D99055 <https://reviews.llvm.org/D99055> (so please hold off on committing this until that one's approved/settled). Specifically: If we don't go in that direction, it seems good that each of these checks are in the format-specific parts of the code, rather than all together in the main part of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99626/new/

https://reviews.llvm.org/D99626



More information about the llvm-commits mailing list