[PATCH] D99626: [llvm-objcopy] Unify format specific options check.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 30 16:00:07 PDT 2021


avl created this revision.
avl added reviewers: MaskRay, dblaikie, alexshap, rupprecht.
Herald added subscribers: abrachet, sbc100, emaste.
Herald added a reviewer: jhenderson.
avl requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

This patch is extracted from D99055 <https://reviews.llvm.org/D99055> to do functional change separately
from pure refactoring. While handling llvm-objcopy command line options
there is a check for options non-supported on the concrete format.
This check is done differently for various formats. Some formats check
for unsupported options before handling normal options. Other formats
check for unsupported options after handling normal options.
This patch makes processing similar for all formats. It firstly checks
for unsupported options and then handle normal options.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D99626

Files:
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99626.334294.patch
Type: text/x-patch
Size: 11279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/85d33fd3/attachment.bin>


More information about the llvm-commits mailing list