[PATCH] D99574: [ARM] [COFF] Properly produce cross-section relative relocations

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp:63
+    }
+    FixupKind = FK_PCRel_4;
+  }
----------------
I'm not sure I understand entirely how this works.  If this is used in a data only table, the data is now PC-relative.  Is that really the same thing?  Everything on COFF is PC-relative if it is base relocated, but that requires generation in the frontend to account for that, which understands the semantics for the data better than we do at this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99574/new/

https://reviews.llvm.org/D99574