[PATCH] D99570: [AMDGPU] Remove outdated TODOs. NFC
Sebastian Neubauer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 06:19:41 PDT 2021
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1c3b74f0ab6d: [AMDGPU] Remove outdated TODOs. NFC (authored by sebastian-ne).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99570/new/
https://reviews.llvm.org/D99570
Files:
llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
Index: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
+++ llvm/lib/Target/AMDGPU/SIFrameLowering.cpp
@@ -951,7 +951,6 @@
assert(Spill.size() == 1);
// Save FP before setting it up.
- // FIXME: This should respect spillSGPRToVGPR;
BuildMI(MBB, MBBI, DL, TII->get(AMDGPU::V_WRITELANE_B32), Spill[0].VGPR)
.addReg(FramePtrReg)
.addImm(Spill[0].Lane)
@@ -969,7 +968,6 @@
assert(Spill.size() == 1);
// Save BP before setting it up.
- // FIXME: This should respect spillSGPRToVGPR;
BuildMI(MBB, MBBI, DL, TII->get(AMDGPU::V_WRITELANE_B32), Spill[0].VGPR)
.addReg(BasePtrReg)
.addImm(Spill[0].Lane)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99570.334135.patch
Type: text/x-patch
Size: 779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210330/9efbdfa2/attachment.bin>
More information about the llvm-commits
mailing list