[PATCH] D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 30 00:23:47 PDT 2021
jhenderson added inline comments.
================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:127
+ InitFileHdr.NumberOfSymTableEntries = Obj.Symbols.size();
+ for (XCOFFYAML::Symbol YamlSym : Obj.Symbols)
+ InitFileHdr.NumberOfSymTableEntries += YamlSym.NumberOfAuxEntries;
----------------
Higuoxing wrote:
>
One better: `const XCOFFYAML::Symbol &YamlSym`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95505/new/
https://reviews.llvm.org/D95505
More information about the llvm-commits
mailing list